refactor autoencoder_magvit tests#13834
Merged
sayakpaul merged 3 commits intoJun 3, 2026
Merged
Conversation
DN6
reviewed
Jun 1, 2026
Collaborator
DN6
left a comment
DN6
left a comment
There was a problem hiding this comment.
@akshan-main Any idea what's going on with the test failures?
Contributor
Author
|
this shouldn't fail. Previous PR failed because of a ruff check |
sayakpaul
approved these changes
Jun 3, 2026
Comment on lines
+105
to
+107
| @pytest.mark.skip("Unsupported test.") | ||
| def test_forward_with_norm_groups(self): | ||
| pass | ||
| super().test_forward_with_norm_groups() |
Member
There was a problem hiding this comment.
(nit): we are skipping anyway, so pass is also fine
Member
|
Failing tests are unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of the ongoing modeling-test migration (following #13369 and #13153). Migrates the AutoencoderKLMagvit test suite to the mixin-based structure (Config + ModelTesterMixin / TrainingTesterMixin / MemoryTesterMixin / NewAutoencoderTesterMixin).
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sayakpaul @DN6